jmcbray/germinal
2
1
Fork 1
Code Issues 5 Pull requests Releases Wiki Activity

Not all relative paths are filtered #16

New issue
Closed
opened 2020-06-13 14:52:32 -04:00 by tobias · 4 comments
tobias commented 2020-06-13 14:52:32 -04:00
Contributor
Copy link

a URL ending in .. is resolved; thus one can list the directory the document root is in. Access is denied since ../ is filtered.

a URL ending in `..` is resolved; thus one can list the directory the document root is in. Access is denied since `../` is filtered.
jmcbray commented 2020-06-13 15:38:03 -04:00
Owner
Copy link

Hecko, thanks for finding this. I think your comment on #17 is supposed to be on this one...

Hecko, thanks for finding this. I think your comment on #17 is supposed to be on this one...
tobias commented 2020-06-13 15:50:30 -04:00
Author
Contributor
Copy link

Jup, the comment was intended to go here. Besides fixing this, I was also thinking whether following symlinks is needed. Otherwise one could restrict access also with realpath to be within the document root.
Thanks to this bug is was able to verify that the systemd sandboxing is working (#15)

Jup, the comment was intended to go here. Besides fixing this, I was also thinking whether following symlinks is needed. Otherwise one could restrict access also with realpath to be within the document root. Thanks to this bug is was able to verify that the systemd sandboxing is working (#15)
jmcbray commented 2020-06-13 16:18:12 -04:00
Owner
Copy link

I think we do not want to follow symlinks, IMO. I was just about to go look up how to canonicalize paths. I've temporarily pushed a super crappy quick fix, but I think your suggestion should be the real fix.

I think we do not want to follow symlinks, IMO. I was just about to go look up how to canonicalize paths. I've temporarily pushed a super crappy quick fix, but I think your suggestion should be the real fix.
tobias commented 2020-06-13 16:31:39 -04:00
Author
Contributor
Copy link

Thank you

Thank you
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
routes
fix-min-ssl-version
config-file
No results found.
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
jmcbray/germinal#16
No description provided.